[PATCH] D40109: [MS] Apply adjustments after storing 'this'
Reid Kleckner via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Nov 16 10:55:36 PST 2017
rnk added a comment.
In https://reviews.llvm.org/D40109#926975, @rnk wrote:
> This seems to cause a crash on startup in some gtest binaries when I self-host, so I guess I should debug that tomorrow before committing. The rest of clang's tests pass. I guess we don't use virtual inheritance. =S
The fix was small: don't adjust 'this' in vtable thunks. The thunk will ultimately delegate to the implementation which does the adjustment.
https://reviews.llvm.org/D40109
More information about the cfe-commits
mailing list