[PATCH] D38921: [analyzer] LoopUnrolling: update the matched assignment operators

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 16 07:11:19 PST 2017


lebedev.ri added a comment.

Not sure how `clang/docs/LibASTMatchersReference.html` is supposed to be updated.



================
Comment at: include/clang/ASTMatchers/ASTMatchers.h:3931
+
+/// \brief Matches all kind of assignment operators.
+///
----------------
Maybe
```
-/// \brief Matches all kind of assignment operators.
+/// \brief Matches all kinds of assignment operators.
```


================
Comment at: include/clang/ASTMatchers/ASTMatchers.h:3938
+/// \endcode
+AST_MATCHER(BinaryOperator, isAssignmentOperator) {
+  return Node.isAssignmentOp();
----------------
Needs unittests, probably in `clang/unittests/ASTMatchers/ASTMatchersNarrowingTest.cpp` ?


https://reviews.llvm.org/D38921





More information about the cfe-commits mailing list