[PATCH] D39571: [clangd] DidChangeConfiguration Notification

Marc-Andre Laperle via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 16 06:05:44 PST 2017


malaperle added inline comments.


================
Comment at: clangd/Protocol.h:295
+
+struct ClangdConfigurationParams {
+
----------------
ilya-biryukov wrote:
> Maybe call it `ClangdConfigurationParamsChange` to make it clear those are diffs, not the actual params?
The idea was that we can reuse the same struct for InitializeParams.initializationOptions


https://reviews.llvm.org/D39571





More information about the cfe-commits mailing list