[PATCH] D39842: Allow to store precompiled preambles in memory.

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov added inline comments.


================
Comment at: lib/Frontend/PrecompiledPreamble.cpp:44
+    SmallString<64> Path;
+    llvm::sys::path::system_temp_directory(/*erasedOnReboot=*/true, Path);
+    llvm::sys::path::append(Path, "___clang_inmemory_preamble___");
----------------
klimek wrote:
> erasedOnReboot seems weird for something that we don't want to have on the actual file system. Why do we even want a temp directory?
Yeah, `erasedOnReboot` seems weird here.
What I really wanted is a filepath that's valid on all platforms and is on an existing drive for Windows, so the value of `erasedOnReboot` doesn't really matter. `system_temp_directory` might be the wrong thing to use for that in the first place. Is there a better alternative I'm missing?


https://reviews.llvm.org/D39842