[PATCH] D20124: [PCH] Serialize skipped preprocessor ranges

[Nikolai Kosjar via Phabricator via cfe-commits]

nik added a comment.

Here are my observations:

- Your test case works fine for me even without having this change applied/build. Looks like this is already fixed in current trunk. Please confirm/test.
- Can you come up with another test case that fixes something that is not yet addressed in trunk?
- It does not fix https://bugs.llvm.org/show_bug.cgi?id=34971

Apart from that the patch applies cleanly and all tests pass (check-clang). However, some new warnings are emitted during building:

  /home/nik/dev/llvm/trunk/source/tools/clang/include/clang/Lex/PreprocessingRecord.h: In constructor ‘clang::PreprocessingRecord::PreprocessingRecord(clang::SourceManager&)’:
  /home/nik/dev/llvm/trunk/source/tools/clang/include/clang/Lex/PreprocessingRecord.h:339:40: warning: ‘clang::PreprocessingRecord::ExternalSource’ will be initialized after [-Wreorder]
  	 ExternalPreprocessingRecordSource *ExternalSource;
  										^~~~~~~~~~~~~~
  /home/nik/dev/llvm/trunk/source/tools/clang/include/clang/Lex/PreprocessingRecord.h:312:10: warning:   ‘bool clang::PreprocessingRecord::SkippedRangesAllLoaded’ [-Wreorder]
  	 bool SkippedRangesAllLoaded;
  		  ^~~~~~~~~~~~~~~~~~~~~~
  /home/nik/dev/llvm/trunk/source/tools/clang/lib/Lex/PreprocessingRecord.cpp:36:1: warning:   when initialized here [-Wreorder]



================
Comment at: lib/Lex/PreprocessingRecord.cpp:339
+
+
 void PreprocessingRecord::RegisterMacroDefinition(MacroInfo *Macro,
----------------
Remove excess new line.


https://reviews.llvm.org/D20124