[PATCH] D40068: Implement more accurate penalty & trade-offs while breaking protruding tokens.

[Manuel Klimek via Phabricator via cfe-commits]

klimek added inline comments.


================
Comment at: unittests/Format/FormatTest.cpp:8007
+            "    \"aaabbbcc ddde \"\n"
+            "    \"efff\");",
             format("someFunction(\"aaabbbcc ddde efff\");",
----------------
krasimir wrote:
> Why did the string got on a newline here?
Because then we break inside the string less often? That seems clearly better than before?


================
Comment at: unittests/Format/FormatTestComments.cpp:2456
                    "       */a);",
-                   getLLVMStyleWithColumns(15)));
+                   getLLVMStyleWithColumns(16)));
 
----------------
krasimir wrote:
> Why change `15` to `16`? The same for the subsequent cases.
Because we're breaking before the comment now (see above), which according to the doc I wrote you agree is better, but changing all the tests seemed to then test something completely different.


https://reviews.llvm.org/D40068