[PATCH] D40108: [clang-tidy] Adding Fuchsia checkers to clang-tidy

Eugene Zelenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 15 18:39:54 PST 2017


Eugene.Zelenko added inline comments.


================
Comment at: clang-tidy/fuchsia/FuchsiaTidyModule.cpp:31
+  void addCheckFactories(ClangTidyCheckFactories &CheckFactories) override {
+
+    CheckFactories.registerCheck<DefaultArgumentsCheck>(
----------------
Please remove empty line.


================
Comment at: clang-tidy/fuchsia/MultipleInheritanceCheck.cpp:100
+            Result.Nodes.getNodeAs<CXXRecordDecl>("decl")) {
+
+    // Check against map to see if if the class inherits from multiple 
----------------
Please remove empty line.


================
Comment at: docs/ReleaseNotes.rst:63
+
+  Check to prevent multiple inheritance in Fuchsia.
+
----------------
//Check to// should be removed, just //Prevent//. Same in other places.


Repository:
  rL LLVM

https://reviews.llvm.org/D40108





More information about the cfe-commits mailing list