[PATCH] D40023: [RISCV] Implement ABI lowering

[Mandeep Singh Grang via Phabricator via cfe-commits]

mgrang added inline comments.


================
Comment at: lib/CodeGen/TargetInfo.cpp:8845
+
+  // Structures with either a non-trivial destructor or a non-trivial
+  // copy constructor are always indirectly.
----------------
Comment sounds incomplete.


================
Comment at: lib/CodeGen/TargetInfo.cpp:8943
+  // Arguments bigger than 2*xlen bytes are passed indirectly.
+  bool IsIndirect = TyInfo.first.getQuantity() > ((2 * XLen) / 8);
+
----------------
Parentheses around 2 * XLen can be skipped.


https://reviews.llvm.org/D40023