[PATCH] D39730: Enabling constructor code completion
Alex Lorenz via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Nov 15 09:49:22 PST 2017
arphaman added a comment.
In https://reviews.llvm.org/D39730#926108, @jkorous-apple wrote:
> Sorry, what do you mean by "this works in the body of the class"?
>
> Definition of constructor inside class definition has been working even before:
>
> struct foo {
> foo();
> f<CODE_COMPLETE_HERE>
> };
>
>
> Do you mean that a test shall be added in order to check that it still works?
You're right, but we don't actually code-complete constructor in this case, but the struct name. I suppose we don't need to complete the constructor here, but we do need the destructor, i.e.:
struct foo {
~<CODE_COMPLETE_HERE>
};
https://reviews.llvm.org/D39730
More information about the cfe-commits
mailing list