[PATCH] D39049: [analyzer] Fix wrong calculation of offset in ArrayBoundsV2

[Gábor Horváth via Phabricator via cfe-commits]

xazax.hun added a comment.

In https://reviews.llvm.org/D39049#910482, @NoQ wrote:

>   // TODO: once the constraint manager is smart enough to handle non simplified
>   // symbolic expressions remove this function. Note that this can not be used in
>   // the constraint manager as is, since this does not handle overflows. It is
>   // safe to assume, however, that memory offsets will not overflow.
>
>
> Wasn't safe enough, i guess.


I agree, we should remove/alter this part of the comment since it is not true.

@danielmarjamaki 
Could you do a similar analysis that I did above to check why does this not work for the multidimensional case? (I.e.: checking what constraints are generated and what the analyzer does with them.)


Repository:
  rL LLVM

https://reviews.llvm.org/D39049