[PATCH] D39900: Refactor ContinuationIndenter's breakProtrudingToken logic into slightly moreorthogonal pieces.
Manuel Klimek via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Nov 14 01:12:17 PST 2017
klimek added a comment.
In https://reviews.llvm.org/D39900#921885, @krasimir wrote:
> Maybe we should further refactor `getRawStringStyle` into `llvm::Optional<std::pair<style, delimiter>> getRawStringStyleAndDelimiter` and that would nicely take care of the duplicated effort?
I thought about that, too, but I'm still convinced the right solution if we really care about the runtime is to cache the result in FormatToken itself.
https://reviews.llvm.org/D39900
More information about the cfe-commits
mailing list