[PATCH] D39622: Fix type debug information generation for enum-based template specialization

David Blaikie via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 13 15:00:27 PST 2017


On Sun, Nov 12, 2017 at 12:53 PM Anton via Phabricator <
reviews at reviews.llvm.org> wrote:

> xgsa added a comment.
>
> In https://reviews.llvm.org/D39622#919579, @aprantl wrote:
>
> > For clarification: what is the "symbols table" you are referring to in
> the description?
>
>
> I meant the data dumped with "nm -an ./test".
>
> By the way, I haven't abandoned the patch, I have found one more case when
> my fix doesn't work and I am working on improvement. Nevertheless, it would
> be helpful to get answers to the questions in this review (about changing
> the "Indentation" field and about the test).
>

I'm confused then - nm's output uses a demangler, the file doesn't actually
have either "Impl<TagType::Tag1>" or "Impl<(TagType)0>" in it.

It's probably not OK/possible to ensure the type always matches lldb's
demangled form. Other produces might have another idea of what its
demangled form looks like.


>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D39622
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20171113/58c61b5a/attachment-0001.html>


More information about the cfe-commits mailing list