[PATCH] D39886: [ASTImporter] Fix wrong conflict detections for unnamed structures

Mon Nov 13 05:02:18 PST 2017

tk1012 added a comment.

Hallo Aleksei and Gábor,

Thank you for your response.

> 1. Are import conflicts for anonymous structures resolved correctly?

In fact, this patch only fixes the unnamed structures that are not anonymous.

In https://reviews.llvm.org/D39886#923188, @tk1012 wrote:

>

I added an inline comment

> 2. Are equal structures present in both TUs imported correctly, without duplication?

As far as my experience, ASTImporter cannot import without duplication when the same structure definition exists in the both TUs ( e.g. include the same header file).
Then, in some cases ( e.g. using ICmpExpr for the imported structures), LLVM asserts and fails in the compilation.

First, I think this situation is not considered in the usage of ASTImporter ( I mean ASTImporter assumes that one structure is defined only once).
But, is this not correct?

In any case, I will check both things and try to test them.

https://reviews.llvm.org/D39886