[PATCH] D39462: [Sema] Implement -Wmaybe-tautological-constant-compare for when the tautologicalness is data model dependent

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Nov 12 00:11:07 PST 2017


rjmccall added a comment.

I don't speak for the entire project, but I'm not sure I'm interested in the diagnostic you're actually offering to contribute here.  It may produce a warning on your specific test case, but I think it's really much too rigid and will lead to massive false positives.  I sketched the basics of a design that I think I could accept; if you don't want to implement it, that's your right, but that doesn't make me more likely to accept what you're willing to implement.


Repository:
  rL LLVM

https://reviews.llvm.org/D39462





More information about the cfe-commits mailing list