[PATCH] D39360: [C++11] Don't put empty quotes in static_assert diagnostic.

Nicolas Lesser via cfe-commits cfe-commits at lists.llvm.org
Sun Nov 12 11:25:17 PST 2017


Agreed! Just wanted to do it but then I noticed that there's already one
that landed in r307791! :)

On Sun, Oct 29, 2017 at 2:06 PM, Kim Gräsman <kim.grasman at gmail.com> wrote:

> A clang-tidy check to remove empty messages from source would be nice,
> though...
>
> - Kim
>
> Den 27 okt. 2017 10:24 fm skrev "Nicolas Lesser via Phabricator" <
> reviews at reviews.llvm.org>:
>
>> Rakete1111 abandoned this revision.
>> Rakete1111 added a comment.
>>
>> @kimgr Well, mostly because they bother me a bit, don't know what others
>> think though. I just thought it would be nice if they didn't appear, mainly
>> because there is no need to show empty quotes in the error message. Hmm,
>> you have a point though... Didn't think of that. Thanks +1
>>
>>
>> https://reviews.llvm.org/D39360
>>
>>
>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20171112/fbd0deaf/attachment.html>


More information about the cfe-commits mailing list