[PATCH] D39937: [Sema] Improve diagnostics for const- and ref-qualified member functions

Jacob Bandes-Storch via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Nov 11 00:31:39 PST 2017


jtbandes created this revision.

Adjust wording for const-qualification mismatch to be a little more clear.

Also add another diagnostic for a ref qualifier mismatch, which previously produced a useless error (this error path is simply very old; see https://reviews.llvm.org/rL119336):

Before:

  error: cannot initialize object parameter of type 'X0' with an expression of type 'X0'

After:

  error: 'this' argument to member function 'rvalue' is an lvalue, but function has rvalue ref-qualifier


https://reviews.llvm.org/D39937

Files:
  include/clang/Basic/DiagnosticSemaKinds.td
  lib/Sema/SemaOverload.cpp
  test/CXX/over/over.match/over.match.funcs/p4-0x.cpp
  test/SemaCXX/copy-initialization.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D39937.122574.patch
Type: text/x-patch
Size: 5591 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20171111/faa86089/attachment.bin>


More information about the cfe-commits mailing list