[PATCH] D39446: [PGO] Detect more structural changes with the stable hash

[Alex Lorenz via Phabricator via cfe-commits]

arphaman added a comment.

Generally it LG



================
Comment at: lib/CodeGen/CodeGenPGO.cpp:244
+  DEFINE_NESTABLE_TRAVERSAL(CXXTryStmt)
+  DEFINE_NESTABLE_TRAVERSAL(CXXCatchStmt)
+
----------------
What about `ObjCAtTryStmt`?


================
Comment at: lib/CodeGen/CodeGenPGO.cpp:321
+        return PGOHash::ReturnStmt;
+      case Stmt::CXXThrowExprClass:
+        return PGOHash::ThrowExpr;
----------------
Might as well include the `ObjCAtThrowStmt` as well.


https://reviews.llvm.org/D39446