[PATCH] D39738: [clangd] Sort completion results.

[Francisco Lopes da Silva via Phabricator via cfe-commits]

francisco.lopes added a comment.

I'm still in the process of construction a general jsonrpc client and didn't start consuming clangd yet. But, I do have previous experience with libclang, and I don't know whether clangd will be able to return completion results at global scope (not necessarily on member access solely), like libclang does. This is my main concern, because global scope completion is one of the most useful use cases, even more in languages like C, but the results can be large and can go at the order of 43k results by simply including a header like windows.h <https://github.com/Valloric/YouCompleteMe/issues/2668>. As I still didn't start consuming clangd, I don't know whether it even supports returns all the results from libclang to let the client do its filtering and sorting.


Repository:
  rL LLVM

https://reviews.llvm.org/D39738