[PATCH] D39838: [clang] [python] [tests] Update priority values in code completion test

Michał Górny via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 9 12:05:08 PST 2017


mgorny added a comment.

In https://reviews.llvm.org/D39838#920399, @ilya-biryukov wrote:

> LGTM.
>
> Can we run those tests as part of `check-all` cmake target or setup a buildbot that runs those? Seems surprising it went unnoticed for so long.


I was thinking of that but I think it'd be nice to find someone who knows them better. I know they're loading `libclang.so` dynamically somehow, and I'm not really sure how to make sure that they're going to test the right library. On Gentoo we run the tests after installing clang to the system.


Repository:
  rL LLVM

https://reviews.llvm.org/D39838





More information about the cfe-commits mailing list