[PATCH] D39857: [AMDGPU] Late parsed / dependent arguments for AMDGPU kernel attributes

[Konstantin Zhuravlyov via Phabricator via cfe-commits]

kzhuravl added a subscriber: cfe-commits.
kzhuravl added a reviewer: aaron.ballman.
kzhuravl added a comment.

Hi Alex, can you rebase on top of trunk (I think you brought in some extra changes from hcc branch) and upload a full diff?



================
Comment at: include/clang/Basic/Attr.td:1328
+              ExprArgument<"Max", 1>,
               StringArgument<"ISA", 1>];
   let Documentation = [AMDGPUFlatWorkGroupSizeDocs];
----------------
Not in trunk.


================
Comment at: include/clang/Basic/Attr.td:1339
+              ExprArgument<"Max", 1>,
               StringArgument<"ISA", 1>];
   let Documentation = [AMDGPUWavesPerEUDocs];
----------------
Not in trunk.


================
Comment at: include/clang/Basic/Attr.td:1361-1370
+def AMDGPUMaxWorkGroupDim : InheritableAttr {
   let Spellings = [CXX11<"","hc_max_workgroup_dim", 201511>];
-  let Args = [IntArgument<"X">,
-              IntArgument<"Y", 1>,
-              IntArgument<"Z", 1>,
+  let Args = [ExprArgument<"X">,
+              ExprArgument<"Y">,
+              ExprArgument<"Z">,
               StringArgument<"ISA", 1>];
   let Subjects = SubjectList<[Function], ErrorDiag>;
----------------
Not in trunk.


https://reviews.llvm.org/D39857