[PATCH] D39852: [clangd] Support returning a limited number of completion results.

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 9 10:45:58 PST 2017


sammccall created this revision.

All results are scored, we only process CodeCompletionStrings for the winners.
We now return CompletionList rather than CompletionItem[] (both are valid).
sortText is now based on CodeCompletionResult::orderedName (mostly the same).

This is the first clangd-only completion option, so plumbing changed.
It requires a small clangd patch (exposing CodeCompletionResult::orderedName).

(This can't usefully be enabled yet: we don't support server-side filtering)


https://reviews.llvm.org/D39852

Files:
  clangd/ClangdLSPServer.cpp
  clangd/ClangdServer.cpp
  clangd/ClangdServer.h
  clangd/ClangdUnit.cpp
  clangd/ClangdUnit.h
  clangd/Protocol.cpp
  clangd/Protocol.h
  test/clangd/authority-less-uri.test
  test/clangd/completion-items-kinds.test
  test/clangd/completion-priorities.test
  test/clangd/completion-qualifiers.test
  test/clangd/completion-snippet.test
  test/clangd/completion.test
  test/clangd/protocol.test
  unittests/clangd/ClangdTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D39852.122272.patch
Type: text/x-patch
Size: 40927 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20171109/01088862/attachment-0001.bin>


More information about the cfe-commits mailing list