[PATCH] D32478: [clang-format] Fix AlignOperands when BreakBeforeBinaryOperators is set

Manuel Klimek via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 9 01:00:24 PST 2017


klimek added a comment.

In https://reviews.llvm.org/D32478#806757, @Typz wrote:

> I renamed the option to `AlignAfterOperator`, is it acceptable now?
>  (I also thought of `UnindentOperator`, but I think it is better to keep the notion of alignment)
>
> Note that this style is used in multiple open-source projects: Skia <https://skia.org/>, parts of QtCreator <https://doc-snapshots.qt.io/qtcreator-extending/coding-style.html> code base (e.g. in multiple plugins: clang, cpptools, android...), the OpenEXR <https://github.com/openexr/openexr> library...


Sorry for the long response time. I don't see this style rule expressed explicitly in the Skia or QtCreator style guides - is this something that just happens to be done sometimes in the code bases? I have problems understanding the rules from the discussion (as well as the code / test tbh), is there a really concise way to give me the core of the idea?


https://reviews.llvm.org/D32478





More information about the cfe-commits mailing list