[PATCH] D39050: Add index-while-building support to Clang

[Marc-Andre Laperle via Phabricator via cfe-commits]

malaperle added inline comments.


================
Comment at: lib/Index/IndexRecordWriter.cpp:155
+    if (!IsNew) {
+      llvm::errs() << "Index: Duplicate USR! " << SymInfo.USR << "\n";
+      // FIXME: print more information so it's easier to find the declaration.
----------------
I'm getting quite a bit of those while indexing Clangd, it looks like it comes from some LLVM/Support headers:
Index: Duplicate USR! c:@N at std@ST>2#NI#Nb at __try_lock_impl
Index: Duplicate USR! c:@N at llvm@ST>1#T at DenseMapInfo
Index: Duplicate USR! c:@N at llvm@ST>1#T at isPodLike
Index: Duplicate USR! c:@N at llvm@N at detail@ST>1#T at unit
Index: Duplicate USR! c:@N at llvm@ST>2#T#T at format_provider
Index: Duplicate USR! c:@N at llvm@ST>2#T#T at format_provider
Index: Duplicate USR! c:@N at llvm@ST>1#T at PointerLikeTypeTraits
Index: Duplicate USR! c:@N at llvm@ST>1#T at simplify_type
Index: Duplicate USR! c:@N at std@ST>1#T at atomic
Index: Duplicate USR! c:@N at llvm@ST>1#T at isPodLike
Index: Duplicate USR! c:@N at llvm@ST>1#T at DenseMapInfo

I think it would be good to have the file name at least in the log. I also assume those duplication are issues that would have to be fixed in USRGenerator (i.e. in separate patches) ?


https://reviews.llvm.org/D39050