[PATCH] D39799: [Tooling] Use FixedCompilationDatabase when `compile_flags.txt` is found.
Manuel Klimek via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Nov 8 06:21:45 PST 2017
klimek added inline comments.
================
Comment at: include/clang/Tooling/CompilationDatabase.h:188
+ static std::unique_ptr<FixedCompilationDatabase>
+ loadFromFile(StringRef Path, std::string &ErrorMsg);
+
----------------
Perhaps loadFromTextFile?
================
Comment at: lib/Tooling/CompilationDatabase.cpp:312
+FixedCompilationDatabase::loadFromFile(StringRef Path, std::string &ErrorMsg) {
+ ErrorMsg.clear();
+ llvm::ErrorOr<std::unique_ptr<llvm::MemoryBuffer>> File =
----------------
I assume we can't use ErrorOr as return value?
https://reviews.llvm.org/D39799
More information about the cfe-commits
mailing list