r317687 - Workaround reverse-iteration buildbot breakages. Filed PR35244.

Ilya Biryukov via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 8 05:05:52 PST 2017


Author: ibiryukov
Date: Wed Nov  8 05:05:52 2017
New Revision: 317687

URL: http://llvm.org/viewvc/llvm-project?rev=317687&view=rev
Log:
Workaround reverse-iteration buildbot breakages. Filed PR35244.

Clang's completion output is non-deterministic, causing test failures
with turned on LLVM_REVERSE_ITERATION.
The workaround is to use CHECK-DAGs for now, will remove them when
PR35244 gets fixed.

Modified:
    cfe/trunk/test/CodeCompletion/qualifiers-as-written.cpp

Modified: cfe/trunk/test/CodeCompletion/qualifiers-as-written.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeCompletion/qualifiers-as-written.cpp?rev=317687&r1=317686&r2=317687&view=diff
==============================================================================
--- cfe/trunk/test/CodeCompletion/qualifiers-as-written.cpp (original)
+++ cfe/trunk/test/CodeCompletion/qualifiers-as-written.cpp Wed Nov  8 05:05:52 2017
@@ -25,6 +25,7 @@ void test() {
   // CHECK-1: COMPLETION: method : [#type#]method(<#type#>, <#foo::type#>, <#::foo::type#>, <#::foo::foo::type#>)
   f
   // RUN: %clang_cc1 -fsyntax-only -code-completion-at=%s:26:3 %s -o - | FileCheck %s --check-prefix=CHECK-2
-  // CHECK-2: COMPLETION: func : [#int#]func(<#foo a#>, <#bar b#>, <#ns::bar c#>, <#ns::baz d#>
-  // CHECK-2: COMPLETION: func : [#int#]func(<#foo::type a#>, <#bar b#>, <#baz c#>
+  // FIXME(ibiryukov): We should get rid of CHECK-DAGs here when completion output is made deterministic (see PR35244).
+  // CHECK-2-DAG: COMPLETION: func : [#int#]func(<#foo a#>, <#bar b#>, <#ns::bar c#>, <#ns::baz d#>
+  // CHECK-2-DAG: COMPLETION: func : [#int#]func(<#foo::type a#>, <#bar b#>, <#baz c#>
 }




More information about the cfe-commits mailing list