[PATCH] D39763: [clang] [python] [tests] Rewrite to use standard unittest module

Michał Górny via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 7 15:05:19 PST 2017


mgorny added a comment.

The diffs aren't very useful since I had to add a class for each test unit and so everything needed reindenting. You can take my word that changes boil down to:

- adding `unittest` import,
- adding class for each test unit and converting the functions into methods (except for some generic utility funcs and vars which I left global scope),
- replacing assertions and other checks with appropriate `self.assert*` methods (especially improving exception checks).

I get the same results (3 failures) with the change as I got before it.


Repository:
  rL LLVM

https://reviews.llvm.org/D39763





More information about the cfe-commits mailing list