[clang-tools-extra] r317584 - [clangd] Fix initialize capabilities response

Sam McCall via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 7 07:49:36 PST 2017


Author: sammccall
Date: Tue Nov  7 07:49:35 2017
New Revision: 317584

URL: http://llvm.org/viewvc/llvm-project?rev=317584&view=rev
Log:
[clangd] Fix initialize capabilities response

Modified:
    clang-tools-extra/trunk/clangd/ClangdLSPServer.cpp
    clang-tools-extra/trunk/test/clangd/initialize-params-invalid.test
    clang-tools-extra/trunk/test/clangd/initialize-params.test

Modified: clang-tools-extra/trunk/clangd/ClangdLSPServer.cpp
URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clangd/ClangdLSPServer.cpp?rev=317584&r1=317583&r2=317584&view=diff
==============================================================================
--- clang-tools-extra/trunk/clangd/ClangdLSPServer.cpp (original)
+++ clang-tools-extra/trunk/clangd/ClangdLSPServer.cpp Tue Nov  7 07:49:35 2017
@@ -36,30 +36,32 @@ replacementsToEdits(StringRef Code,
 
 void ClangdLSPServer::onInitialize(Ctx C, InitializeParams &Params) {
   C.reply(json::obj{
-      {"textDocumentSync", 1},
-      {"documentFormattingProvider", true},
-      {"documentRangeFormattingProvider", true},
-      {"documentOnTypeFormattingProvider",
-       json::obj{
-           {"firstTriggerCharacter", "}"},
-           {"moreTriggerCharacter", {}},
-       }},
-      {"codeActionProvider", true},
-      {"completionProvider",
-       json::obj{
-           {"resolveProvider", false},
-           {"triggerCharacters", {".", ">", ":"}},
-       }},
-      {"signatureHelpProvider",
-       json::obj{
-           {"triggerCharacters", {"(", ","}},
-       }},
-      {"definitionProvider", true},
-      {"executeCommandProvider",
-       json::obj{
-           {"commands", {ExecuteCommandParams::CLANGD_APPLY_FIX_COMMAND}},
-       }},
-  });
+      {{"capabilities",
+        json::obj{
+            {"textDocumentSync", 1},
+            {"documentFormattingProvider", true},
+            {"documentRangeFormattingProvider", true},
+            {"documentOnTypeFormattingProvider",
+             json::obj{
+                 {"firstTriggerCharacter", "}"},
+                 {"moreTriggerCharacter", {}},
+             }},
+            {"codeActionProvider", true},
+            {"completionProvider",
+             json::obj{
+                 {"resolveProvider", false},
+                 {"triggerCharacters", {".", ">", ":"}},
+             }},
+            {"signatureHelpProvider",
+             json::obj{
+                 {"triggerCharacters", {"(", ","}},
+             }},
+            {"definitionProvider", true},
+            {"executeCommandProvider",
+             json::obj{
+                 {"commands", {ExecuteCommandParams::CLANGD_APPLY_FIX_COMMAND}},
+             }},
+        }}}});
   if (Params.rootUri && !Params.rootUri->file.empty())
     Server.setRootPath(Params.rootUri->file);
   else if (Params.rootPath && !Params.rootPath->empty())

Modified: clang-tools-extra/trunk/test/clangd/initialize-params-invalid.test
URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clangd/initialize-params-invalid.test?rev=317584&r1=317583&r2=317584&view=diff
==============================================================================
--- clang-tools-extra/trunk/test/clangd/initialize-params-invalid.test (original)
+++ clang-tools-extra/trunk/test/clangd/initialize-params-invalid.test Tue Nov  7 07:49:35 2017
@@ -8,34 +8,36 @@ Content-Length: 142
 #      CHECK:  "id": 0,
 # CHECK-NEXT:  "jsonrpc": "2.0",
 # CHECK-NEXT:  "result": {
-# CHECK-NEXT:    "codeActionProvider": true,
-# CHECK-NEXT:    "completionProvider": {
-# CHECK-NEXT:      "resolveProvider": false,
-# CHECK-NEXT:      "triggerCharacters": [
-# CHECK-NEXT:        ".",
-# CHECK-NEXT:        ">",
-# CHECK-NEXT:        ":"
-# CHECK-NEXT:      ]
-# CHECK-NEXT:    },
-# CHECK-NEXT:    "definitionProvider": true,
-# CHECK-NEXT:    "documentFormattingProvider": true,
-# CHECK-NEXT:    "documentOnTypeFormattingProvider": {
-# CHECK-NEXT:      "firstTriggerCharacter": "}",
-# CHECK-NEXT:      "moreTriggerCharacter": []
-# CHECK-NEXT:    },
-# CHECK-NEXT:    "documentRangeFormattingProvider": true,
-# CHECK-NEXT:    "executeCommandProvider": {
-# CHECK-NEXT:      "commands": [
-# CHECK-NEXT:        "clangd.applyFix"
-# CHECK-NEXT:      ]
-# CHECK-NEXT:    },
-# CHECK-NEXT:    "signatureHelpProvider": {
-# CHECK-NEXT:      "triggerCharacters": [
-# CHECK-NEXT:        "(",
-# CHECK-NEXT:        ","
-# CHECK-NEXT:      ]
-# CHECK-NEXT:    },
-# CHECK-NEXT:    "textDocumentSync": 1
+# CHECK-NEXT:    "capabilities": {
+# CHECK-NEXT:      "codeActionProvider": true,
+# CHECK-NEXT:      "completionProvider": {
+# CHECK-NEXT:        "resolveProvider": false,
+# CHECK-NEXT:        "triggerCharacters": [
+# CHECK-NEXT:          ".",
+# CHECK-NEXT:          ">",
+# CHECK-NEXT:          ":"
+# CHECK-NEXT:        ]
+# CHECK-NEXT:      },
+# CHECK-NEXT:      "definitionProvider": true,
+# CHECK-NEXT:      "documentFormattingProvider": true,
+# CHECK-NEXT:      "documentOnTypeFormattingProvider": {
+# CHECK-NEXT:        "firstTriggerCharacter": "}",
+# CHECK-NEXT:        "moreTriggerCharacter": []
+# CHECK-NEXT:      },
+# CHECK-NEXT:      "documentRangeFormattingProvider": true,
+# CHECK-NEXT:      "executeCommandProvider": {
+# CHECK-NEXT:        "commands": [
+# CHECK-NEXT:          "clangd.applyFix"
+# CHECK-NEXT:        ]
+# CHECK-NEXT:      },
+# CHECK-NEXT:      "signatureHelpProvider": {
+# CHECK-NEXT:        "triggerCharacters": [
+# CHECK-NEXT:          "(",
+# CHECK-NEXT:          ","
+# CHECK-NEXT:        ]
+# CHECK-NEXT:      },
+# CHECK-NEXT:      "textDocumentSync": 1
+# CHECK-NEXT:    }
 # CHECK-NEXT:  }
 Content-Length: 44
 

Modified: clang-tools-extra/trunk/test/clangd/initialize-params.test
URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clangd/initialize-params.test?rev=317584&r1=317583&r2=317584&view=diff
==============================================================================
--- clang-tools-extra/trunk/test/clangd/initialize-params.test (original)
+++ clang-tools-extra/trunk/test/clangd/initialize-params.test Tue Nov  7 07:49:35 2017
@@ -8,34 +8,36 @@ Content-Length: 143
 #      CHECK:  "id": 0,
 # CHECK-NEXT:  "jsonrpc": "2.0",
 # CHECK-NEXT:  "result": {
-# CHECK-NEXT:    "codeActionProvider": true,
-# CHECK-NEXT:    "completionProvider": {
-# CHECK-NEXT:      "resolveProvider": false,
-# CHECK-NEXT:      "triggerCharacters": [
-# CHECK-NEXT:        ".",
-# CHECK-NEXT:        ">",
-# CHECK-NEXT:        ":"
-# CHECK-NEXT:      ]
-# CHECK-NEXT:    },
-# CHECK-NEXT:    "definitionProvider": true,
-# CHECK-NEXT:    "documentFormattingProvider": true,
-# CHECK-NEXT:    "documentOnTypeFormattingProvider": {
-# CHECK-NEXT:      "firstTriggerCharacter": "}",
-# CHECK-NEXT:      "moreTriggerCharacter": []
-# CHECK-NEXT:    },
-# CHECK-NEXT:    "documentRangeFormattingProvider": true,
-# CHECK-NEXT:    "executeCommandProvider": {
-# CHECK-NEXT:      "commands": [
-# CHECK-NEXT:        "clangd.applyFix"
-# CHECK-NEXT:      ]
-# CHECK-NEXT:    },
-# CHECK-NEXT:    "signatureHelpProvider": {
-# CHECK-NEXT:      "triggerCharacters": [
-# CHECK-NEXT:        "(",
-# CHECK-NEXT:        ","
-# CHECK-NEXT:      ]
-# CHECK-NEXT:    },
-# CHECK-NEXT:    "textDocumentSync": 1
+# CHECK-NEXT:    "capabilities": {
+# CHECK-NEXT:      "codeActionProvider": true,
+# CHECK-NEXT:      "completionProvider": {
+# CHECK-NEXT:        "resolveProvider": false,
+# CHECK-NEXT:        "triggerCharacters": [
+# CHECK-NEXT:          ".",
+# CHECK-NEXT:          ">",
+# CHECK-NEXT:          ":"
+# CHECK-NEXT:        ]
+# CHECK-NEXT:      },
+# CHECK-NEXT:      "definitionProvider": true,
+# CHECK-NEXT:      "documentFormattingProvider": true,
+# CHECK-NEXT:      "documentOnTypeFormattingProvider": {
+# CHECK-NEXT:        "firstTriggerCharacter": "}",
+# CHECK-NEXT:        "moreTriggerCharacter": []
+# CHECK-NEXT:      },
+# CHECK-NEXT:      "documentRangeFormattingProvider": true,
+# CHECK-NEXT:      "executeCommandProvider": {
+# CHECK-NEXT:        "commands": [
+# CHECK-NEXT:          "clangd.applyFix"
+# CHECK-NEXT:        ]
+# CHECK-NEXT:      },
+# CHECK-NEXT:      "signatureHelpProvider": {
+# CHECK-NEXT:        "triggerCharacters": [
+# CHECK-NEXT:          "(",
+# CHECK-NEXT:          ","
+# CHECK-NEXT:        ]
+# CHECK-NEXT:      },
+# CHECK-NEXT:      "textDocumentSync": 1
+# CHECK-NEXT:    }
 # CHECK-NEXT:  }
 Content-Length: 44
 




More information about the cfe-commits mailing list