[PATCH] D39705: [clangd] Fix opening declarations located in non-preamble inclusion
    Sam McCall via Phabricator via cfe-commits 
    cfe-commits at lists.llvm.org
       
    Tue Nov  7 01:20:01 PST 2017
    
    
  
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: clangd/ClangdUnit.cpp:970
+            SourceMgr.getFileEntryForID(SourceMgr.getFileID(LocStart))) {
+      StringRef FilePath = F->tryGetRealPathName();
+      if (FilePath.empty())
----------------
Can you add a comment about when this is needed?
like // Non-preamble included files may have relative paths.
Repository:
  rL LLVM
https://reviews.llvm.org/D39705
    
    
More information about the cfe-commits
mailing list