[PATCH] D38680: [libunwind] Fix handling of DW_CFA_GNU_args_size

Martin Storsjö via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 6 13:30:18 PST 2017


mstorsjo added a comment.

In https://reviews.llvm.org/D38680#903203, @joerg wrote:

> I've looked at this in some detail now. I'm not exactly sure yet why it is broken. The patch seems quite wrong to me. DW_CFA_GNU_args_size should be applied only when unwinding a call instruction and that regard, the commit message of the original change is quite correct. What I am still trying to understand is how the precise unwind frame disagrees with the unwinder.


@joerg Any update on this matter, how should we move forward with unbreaking the unwinding on i386?


https://reviews.llvm.org/D38680





More information about the cfe-commits mailing list