[PATCH] D39682: [analyzer] Fix a crash on logical operators with vectors.
Gábor Horváth via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Nov 6 04:51:57 PST 2017
xazax.hun accepted this revision.
xazax.hun added a comment.
This revision is now accepted and ready to land.
LGTM!
================
Comment at: lib/StaticAnalyzer/Core/ExprEngineC.cpp:633
+ // modeled as short-circuit in Clang CFG but this is incorrect.
+ StmtNodeBuilder Bldr(Pred, Dst, *currBldrCtx);
+ // Do not set the value for the expression. It'd be UnknownVal by default.
----------------
I was wondering maybe moving this code down a bit you could reuse the `StmtNodeBuilder` bellow and the could be slightly shorter. But I guess it is just the matter of taste.
https://reviews.llvm.org/D39682
More information about the cfe-commits
mailing list