[PATCH] D39640: [lit] Set shlibpath_var on Solaris

[Rainer Orth via Phabricator via cfe-commits]

ro created this revision.
Herald added a subscriber: fedor.sergeev.

During make check-all on Solaris, lit complains

llvm-lit: /vol/gcc/src/llvm/llvm/dist/tools/clang/test/Unit/lit.cfg.py:57: warning: unable to inject shared library path on 'SunOS'

The following patch avoids this: Solaris uses LD_LIBRARY_PATH like several other targets.

In theory, once could also handle LD_LIBRARY_PATH_{32,64} which take precedence over
LD_LIBRARY_PATH if set, but let's cross that bridge when we get there.


https://reviews.llvm.org/D39640

Files:
  test/Unit/lit.cfg.py


Index: test/Unit/lit.cfg.py
===================================================================
--- test/Unit/lit.cfg.py
+++ test/Unit/lit.cfg.py
@@ -36,7 +36,7 @@
         config.environment[symbolizer] = os.environ[symbolizer]
 
 def find_shlibpath_var():
-    if platform.system() in ['Linux', 'FreeBSD', 'NetBSD']:
+    if platform.system() in ['Linux', 'FreeBSD', 'NetBSD', 'SunOS']:
         yield 'LD_LIBRARY_PATH'
     elif platform.system() == 'Darwin':
         yield 'DYLD_LIBRARY_PATH'


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D39640.121626.patch
Type: text/x-patch
Size: 498 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20171105/41ae5266/attachment.bin>