[PATCH] D39622: Fix type debug information generation for enum-based template specialization

[Anton via Phabricator via cfe-commits]

xgsa added inline comments.


================
Comment at: include/clang/AST/PrettyPrinter.h:227
+
+  /// \brief Use formatting compatible with ABI specification. It is necessary for
+  /// saving entities into debug tables which have to be compatible with
----------------
aprantl wrote:
> xgsa wrote:
> > aprantl wrote:
> > > Te \brief is redundant and can be omitted.
> > I reviewed the other descriptions once again and I suppose it would be more consistent to have "\brief Use formatting compatible with ABI specification." and the rest of the description as a separate paragraph. Don't you mind against such fix?
> This is obviously not super important, but since you asked: our policy for how we use Doxygen has evolved over time, and this file represents an older version of that policy. The right thing to do would be to first commit a cleanup patch that removes all existing `\brief` occurrences from the file and then land the patch.
Thank you for clarification, I don't mind doing the right thing: https://reviews.llvm.org/D39633

Still, I don't have rights to commit the patch, so somebody should commit it anyway.


Repository:
  rL LLVM

https://reviews.llvm.org/D39622