[PATCH] D39534: [libunwind] Add ifdefs around ELF specific parts of UnwindRegisters*.S for ARM

Martin Storsjö via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Nov 4 14:41:47 PDT 2017


mstorsjo added a comment.

In https://reviews.llvm.org/D39534#915938, @jroelofs wrote:

> i.e. should this be keyed off of `__ARM_EABI__` instead?


I'm not really sure. As I quoted earlier, the exact case for enabling these directives in the LLVM codebase right now is `(!IsMachO && !IsCOFF)`.

We could make this `!defined(__MACH__) && !defined(_WIN32)`, but I felt that `defined(__ELF__)` was more readable.

I'm not familiar enough with the other ARM configurations to know what makes most sense for them. Which ones might I be missing here - non-EABI ELF configurations, or non-ELF EABI configurations, or both? If it's non-EABI ELF configurations, the current directive should be fine I think.


Repository:
  rL LLVM

https://reviews.llvm.org/D39534





More information about the cfe-commits mailing list