[PATCH] D39622: Fix type debug information generation for enum-based template specialization

[Anton via Phabricator via cfe-commits]

xgsa added inline comments.


================
Comment at: include/clang/AST/PrettyPrinter.h:68
   /// \brief The number of spaces to use to indent each line.
-  unsigned Indentation : 8;
+  unsigned Indentation : 7;
 
----------------
aprantl wrote:
> this change looks like it has the potential to break existing code.
If not to change the size of this field, the overall size of the PrintingPolicy will exceed 32 bits, so it won't fit a CPU register on 32-bit systems and will be less lightweight. Is it OK, should this line to be reverted?


================
Comment at: include/clang/AST/PrettyPrinter.h:227
+
+  /// \brief Use formatting compatible with ABI specification. It is necessary for
+  /// saving entities into debug tables which have to be compatible with
----------------
aprantl wrote:
> Te \brief is redundant and can be omitted.
I reviewed the other descriptions once again and I suppose it would be more consistent to have "\brief Use formatting compatible with ABI specification." and the rest of the description as a separate paragraph. Don't you mind against such fix?


Repository:
  rL LLVM

https://reviews.llvm.org/D39622