[PATCH] D38976: [OpenMP] Add implicit data sharing support when offloading to NVIDIA GPUs using OpenMP device offloading

Jonas Hahnfeld via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 3 12:48:08 PDT 2017


Hahnfeld added inline comments.


================
Comment at: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp:2393
+
+  // Level0(CGF);
+
----------------
Is this meant to be a comment or should there be something happening here?


================
Comment at: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp:2396
+  CGF.EmitBranch(AfterBB);
+  if (NextBB)
+    CGF.EmitBlock(NextBB);
----------------
Especially, `NextBB` can never be anything else than `nullptr`...


Repository:
  rL LLVM

https://reviews.llvm.org/D38976





More information about the cfe-commits mailing list