[PATCH] D35472: Implement P0463R1: "Endian just Endian"

Eric Fiselier via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 3 12:41:21 PDT 2017


EricWF requested changes to this revision.
EricWF added inline comments.
This revision now requires changes to proceed.


================
Comment at: include/type_traits:4746
+    big    = 0xFACE,
+#if _LIBCPP_LITTLE_ENDIAN
+    native = little
----------------
These macros have been changed to be `#ifdef` style.


================
Comment at: include/type_traits:4750
+    native = big
+#else
+    native = 0xCAFE
----------------
Does this else case ever actually happen? 


https://reviews.llvm.org/D35472





More information about the cfe-commits mailing list