[PATCH] D38688: [clang-tidy] Misc redundant expressions checker updated for macros

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman accepted this revision.
aaron.ballman added a comment.

Aside from some minor commenting nits, this LGTM.



================
Comment at: clang-tidy/misc/RedundantExpressionCheck.cpp:445
 
+  // Do not bind to double negation, it is uneffective.
   const auto NegateNegateRelationalExpr =
----------------
aaron.ballman wrote:
> I understand the first part of the comment, but not the second part -- why is double negation ineffective?
> 
> (Btw, typo: unaffective -> ineffective)
Comment is missing a full stop at the end.


================
Comment at: clang-tidy/misc/RedundantExpressionCheck.cpp:377
 // Match a binary operator between a symbolic expression and an integer constant
-// expression.
+// expression
 static ast_matchers::internal::Matcher<Expr>
----------------
This commenting change is incorrect, the comment should end with a full stop.


https://reviews.llvm.org/D38688