r317294 - [analyzer] [NFC] very minor ExprEngineC refactoring

George Karpenkov via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 2 17:41:29 PDT 2017


Author: george.karpenkov
Date: Thu Nov  2 17:41:29 2017
New Revision: 317294

URL: http://llvm.org/viewvc/llvm-project?rev=317294&view=rev
Log:
[analyzer] [NFC] very minor ExprEngineC refactoring

Differential Revision: https://reviews.llvm.org/D39577

Modified:
    cfe/trunk/lib/StaticAnalyzer/Core/ExprEngineC.cpp

Modified: cfe/trunk/lib/StaticAnalyzer/Core/ExprEngineC.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/StaticAnalyzer/Core/ExprEngineC.cpp?rev=317294&r1=317293&r2=317294&view=diff
==============================================================================
--- cfe/trunk/lib/StaticAnalyzer/Core/ExprEngineC.cpp (original)
+++ cfe/trunk/lib/StaticAnalyzer/Core/ExprEngineC.cpp Thu Nov  2 17:41:29 2017
@@ -92,12 +92,10 @@ void ExprEngine::VisitBinaryOperator(con
       // Process non-assignments except commas or short-circuited
       // logical expressions (LAnd and LOr).
       SVal Result = evalBinOp(state, Op, LeftV, RightV, B->getType());
-      if (Result.isUnknown()) {
-        Bldr.generateNode(B, *it, state);
-        continue;
+      if (!Result.isUnknown()) {
+        state = state->BindExpr(B, LCtx, Result);
       }
 
-      state = state->BindExpr(B, LCtx, Result);
       Bldr.generateNode(B, *it, state);
       continue;
     }




More information about the cfe-commits mailing list