[PATCH] D39534: [libunwind] Add ifdefs around ELF specific parts of UnwindRegisters*.S for ARM

Saleem Abdulrasool via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 2 13:33:24 PDT 2017


compnerd requested changes to this revision.
compnerd added inline comments.
This revision now requires changes to proceed.


================
Comment at: src/UnwindRegistersRestore.S:396
   .fpu vfpv3-d16
+#endif
 DEFINE_LIBUNWIND_PRIVATE_FUNCTION(_ZN9libunwind13Registers_arm19restoreVFPWithFLDMDEPy)
----------------
This really isn't an ELF vs COFF/Mach-O thing.  Does MASM let you do something similar?  This should at the very least be `!defined(_WIN32)`.  The same throughout.


https://reviews.llvm.org/D39534





More information about the cfe-commits mailing list