[PATCH] D39086: Performance tracing facility for clangd.

[Sam McCall via Phabricator via cfe-commits]

sammccall added inline comments.


================
Comment at: clangd/Trace.h:38
+  // Starts a sessions capturing trace events and writing Trace Event JSON.
+  static std::unique_ptr<Session> createJSON(llvm::raw_ostream &OS);
+  ~Session();
----------------
ioeric wrote:
> `createJSON` is a bit confusing... maybe just `create` since json is just the underlying representation which users don't have to know about?
I think later we might have an API for non-JSON sessions (crazy google internal tracing tools) but until then, `create` is a fine name.


https://reviews.llvm.org/D39086