[PATCH] D39505: [OpenMP] Show error if VLAs are not supported
John McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Nov 1 19:39:12 PDT 2017
rjmccall added inline comments.
================
Comment at: include/clang/Basic/TargetInfo.h:944
+ /// \brief Whether target supports variable-length arrays.
+ bool isVLASupported() const { return VLASupported; }
+
----------------
The way you've written this makes it sound like "does the target support VLAs?", but the actual semantic checks treat it as "do OpenMP devices on this target support VLAs?" Maybe there should be a more specific way to query things about OpenMP devices instead of setting a global flag for the target?
https://reviews.llvm.org/D39505
More information about the cfe-commits
mailing list