[PATCH] D39462: [Sema] Implement -Wmaybe-tautological-constant-compare for when the tautologicalness is data model dependent

Eli Friedman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 31 16:29:25 PDT 2017


efriedma added a comment.

> The internal canonical types are compared, so all this typedef sugar will be silently ignored.

Yes, and that's precisely the problem.  On many 32-bit platforms, both "size_t" and "uint32_t" are typedefs for "unsigned int"; on some 32-bit platforms, "size_t" is an "unsigned long".  So whether this patch suppresses the warning for a comparison between size_t and uint32_t depends on the target ABI.


Repository:
  rL LLVM

https://reviews.llvm.org/D39462





More information about the cfe-commits mailing list