[PATCH] D39204: [CodeGen] __builtin_sqrt should map to the compiler's intrinsic sqrt function

Sanjay Patel via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 31 12:36:15 PDT 2017


spatel added a comment.

In https://reviews.llvm.org/D39204#912084, @efriedma wrote:

> Let's do this one step at a time; first this patch, then fix the __builtin_* functions to use "e", then add all the missing cases CodeGenFunction::EmitBuiltinExpr.


Sounds good.

> This patch LGTM, assuming you fix the commit message (and the title on Phabricator) to properly describe the change.

Sure - I didn't know if we prefer to leave the title for the sake of email thread continuity on the list or not, but I'll update that now.


https://reviews.llvm.org/D39204





More information about the cfe-commits mailing list