[PATCH] D39428: [Analyzer] As suggested, use value storage for BodyFarm

[George Karpenkov via Phabricator via cfe-commits]

george.karpenkov added a comment.

@xazax.hun I'm really not convinced:

  george@/Volumes/Transcend/code/llvm (master)≻ rg "\w+\&" tools/clang/include/clang/StaticAnalyzer
  tools/clang/include/clang/StaticAnalyzer/Core/Checker.h
  31:  static void _checkDecl(void *checker, const Decl *D, AnalysisManager& mgr,
  50:  static void _checkBody(void *checker, const Decl *D, AnalysisManager& mgr,
  67:                                         AnalysisManager& mgr,
  489:raw_ostream& operator<<(raw_ostream &Out, const CheckerBase &Checker);
  554:  /*implicit*/ operator bool&() { return val; }
  555:  /*implicit*/ operator const bool&() const { return val; }
  
  tools/clang/include/clang/StaticAnalyzer/Core/CheckerManager.h
  170:  void runCheckersOnASTDecl(const Decl *D, AnalysisManager& mgr,
  174:  void runCheckersOnASTBody(const Decl *D, AnalysisManager& mgr,
  400:  typedef CheckerFn<void (const Decl *, AnalysisManager&, BugReporter &)>
  469:                          AnalysisManager&, BugReporter &)>
  ...

On top of that, reference is part of the type, not part of the variable name,


https://reviews.llvm.org/D39428