[PATCH] D39462: [Sema] Implement -Wmaybe-tautological-constant-compare for when the tautologicalness is data model dependent

[John McCall via Phabricator via cfe-commits]

rjmccall added a comment.

The actual choice of integer type is not stable across targets any more than the size is.  In practice, people often don't use int and long, they use standard typedefs like size_t and uint64_t, but the actual type chosen for size_t is arbitrary when there are multiple types at that bit-width.  So I'm concerned that you're suppressing more than you think here and still not going to satisfy people.

Also, "data model" is not a term in use.  Use "target" or "target platform".


Repository:
  rL LLVM

https://reviews.llvm.org/D39462