[PATCH] D39204: [CodeGen] __builtin_sqrt should map to the compiler's intrinsic sqrt function

[Sanjay Patel via Phabricator via cfe-commits]

spatel added a comment.

In https://reviews.llvm.org/D39204#911316, @efriedma wrote:

> > I was going to include the builtins too, but that exposes another bug (marked here with FIXME) - the builtins are all defined 'const'.
>
> Probably just need to change c->e in Builtins.def?


Yes - at least that made sqrt behave like I expected. So I think it's really just a question of what order and combination that we want to fix this in:

1. Just the sqrt libcalls in this patch.
2. Fix both sqrt libcalls and __builtin_sqrt in this patch.
3. Fix all libm libcalls and builtins simultaneously.


https://reviews.llvm.org/D39204