[PATCH] D39446: [PGO] Detect more structural changes with the stable hash

[Alex Lorenz via Phabricator via cfe-commits]

arphaman added inline comments.


================
Comment at: lib/CodeGen/CodeGenPGO.cpp:186
+    if (Hash.getHashVersion() != PGO_HASH_V1)
+      Type = getHashType(Hash.getHashVersion(), S);
+
----------------
Am I missing something or will this call always return the same type as before since the first `if` will weed out statements which have hash only in v2 (since `getHashType(PGO_HASH_V1, S)` will return `None` for the new statements)?


https://reviews.llvm.org/D39446