[PATCH] D39008: [CodeGen] Propagate may-alias'ness of lvalues with TBAA info
John McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sun Oct 29 23:41:56 PDT 2017
rjmccall added a comment.
Looks good, but you missed updating equality/hashing for the new Kind field.
================
Comment at: lib/CodeGen/CodeGenTBAA.h:71
AccessType == Other.AccessType &&
Offset == Other.Offset;
}
----------------
This needs to factor in the Kind.
================
Comment at: lib/CodeGen/CodeGenTBAA.h:205
DenseMapInfo<MDNode *>::getHashValue(Val.AccessType) ^
DenseMapInfo<uint64_t>::getHashValue(Val.Offset);
}
----------------
This needs to factor in the Kind.
https://reviews.llvm.org/D39008
More information about the cfe-commits
mailing list