[PATCH] D38110: [libunwind][MIPS]: Add support for unwinding in O32 and N64 processes.

[Saleem Abdulrasool via Phabricator via cfe-commits]

compnerd added inline comments.


================
Comment at: include/__libunwind_config.h:69
+#  define _LIBUNWIND_CURSOR_SIZE 47
+#  define _LIBUNWIND_HIGHEST_DWARF_REGISTER 65
 # else
----------------
Can we sink the two cases into the `__mips__` case?  Something like:

    #if defined(__mips__)
    # if defined(_ABIO32)
    # elif defined(_ABIO64)
    # elif defined(_ABIN32)
    # elif defined(_ABI64)
    # else
    #   error "unknown MIPS ABI"
    # endif
    #else


================
Comment at: src/Registers.hpp:2063
+  void        jumpto();
+  static int  lastDwarfRegNum() { return 31; }
+
----------------
I believe we have a macro for this.


https://reviews.llvm.org/D38110