[PATCH] D38985: [refactor] Add support for editor commands that connect IDEs/editors to the refactoring actions

Eric Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 27 04:23:50 PDT 2017


ioeric accepted this revision.
ioeric added a comment.

lg



================
Comment at: include/clang/Tooling/Refactoring/RefactoringActionRule.h:48
+
+  // static const RefactoringDescriptor &describe() = 0;
 };
----------------
A comment would be nice here.


================
Comment at: lib/Tooling/Refactoring/RefactoringActions.cpp:28
+
+// FIXME: Remove the Actions alltogether.
+class ExtractRefactoring final : public RefactoringAction {
----------------
Maybe I'm missing the context here... Why do we want to remove the actions?


Repository:
  rL LLVM

https://reviews.llvm.org/D38985





More information about the cfe-commits mailing list